[tor-bugs] #29217 [Core Tor/Tor]: Script to add new tor files and modules in rust and/or C

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Aug 2 05:31:57 UTC 2019


#29217: Script to add new tor files and modules in rust and/or C
--------------------------------------------+------------------------------
 Reporter:  nickm                           |          Owner:  (none)
     Type:  defect                          |         Status:  new
 Priority:  Medium                          |      Milestone:  Tor:
                                            |  0.4.2.x-final
Component:  Core Tor/Tor                    |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  network-team-roadmap-september  |  Actual Points:
Parent ID:                                  |         Points:  2
 Reviewer:                                  |        Sponsor:
                                            |  Sponsor31-can
--------------------------------------------+------------------------------

Comment (by teor):

 Nick, it looks like add_c_file.py was added in commit 2f31c8146f in
 0.4.1.2-alpha.

 But it has a bug: the suggested usage fails with:
 {{{
 $ scripts/maint/add_c_file.py ./src/feature/dirauth/ocelot.c
 Made files successfully but couldn't identify include.am for
 ./src/feature/dirauth/ocelot.c
 Exit 1
 }}}

 The correct usage has no "./":
 {{{
 $ scripts/maint/add_c_file.py src/feature/dirauth/ocelot.c
 }}}

 We should fix the usage, or make topdir_file() use python's canonical path
 functions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29217#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list