[tor-bugs] #15125 [Obfuscation/meek]: meek-client-torbrowser does not use signals well

[Tor Bug Tracker & Wiki]

#15125: meek-client-torbrowser does not use signals well
------------------------------+-----------------------------
 Reporter:  infinity0         |          Owner:  dcf
     Type:  defect            |         Status:  merge_ready
 Priority:  Medium            |      Milestone:
Component:  Obfuscation/meek  |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:                    |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:  cohosh            |        Sponsor:
------------------------------+-----------------------------

Comment (by dcf):

 Thank you for reviewing, I appreciate it.

 Replying to [comment:14 cohosh]:
 > Is there a reason to have four separate if statements here

 Thanks for commenting on this. You're right. For some reason I was
 thinking that you had to do all the `wg.Add` before any `wg.Done`. But
 looking at [https://golang.org/pkg/sync/#example_WaitGroup the example for
 WaitGroup], there's actually no problem. I made your suggested change
 [https://gitweb.torproject.org/pluggable-
 transports/meek.git/commit/?h=bug25613&id=ca7f9a9ae01a82c04f93c14b4cbd374441713001
 here], then I merged and tagged [https://gitweb.torproject.org/pluggable-
 transports/meek.git/log/?h=0.32 0.32].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15125#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online