[tor-bugs] #30308 [Core Tor/Tor]: Use tor_mem_is_zero to check for broken node identity in node_is_a_configured_bridge()

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Apr 30 14:10:02 UTC 2019


#30308: Use tor_mem_is_zero to check for broken node identity in
node_is_a_configured_bridge()
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-performance tor-hs path-         |  Actual Points:  .1
  selection refactoring tor-dos                  |
Parent ID:  #30291                               |         Points:
 Reviewer:  ahf                                  |        Sponsor:
                                                 |  Sponsor27-can
-------------------------------------------------+-------------------------
Changes (by ahf):

 * status:  needs_review => merge_ready


Comment:

 Looks good. I couldn't come up with additional cases to check for with the
 new case, but it seems like a smart idea to have the fallback mechanism to
 the old implementation.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30308#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list