[tor-bugs] #30308 [Core Tor/Tor]: Use tor_mem_is_zero to check for broken node identity in node_is_a_configured_bridge()

[Tor Bug Tracker & Wiki]

#30308: Use tor_mem_is_zero to check for broken node identity in
node_is_a_configured_bridge()
-------------------------+-------------------------------------------------
     Reporter:  nickm    |      Owner:  nickm
         Type:  defect   |     Status:  assigned
     Priority:  Medium   |  Milestone:  Tor: 0.4.1.x-final
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  tor-performance tor-hs path-
     Severity:  Normal   |  selection refactoring tor-dos
Actual Points:           |  Parent ID:  #30291
       Points:           |   Reviewer:
      Sponsor:           |
  Sponsor27-can          |
-------------------------+-------------------------------------------------
 In node_is_a_configured_bridge(), we use `BUG(tor_digest_is_zero(...))` to
 check for a broken node_t whose digest is not set.  But that's overkill:
 tor_digest_is_zero() uses the slow constant-time tor_memeq(), and this is
 a case where we will hit a BUG().

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30308>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online