[tor-bugs] #29374 [Metrics/Onionperf]: Analysis files sometimes present negative numbers in the payload_progress field

[Tor Bug Tracker & Wiki]

#29374: Analysis files sometimes present negative numbers in the payload_progress
field
-----------------------------------+------------------------------
 Reporter:  irl                    |          Owner:  metrics-team
     Type:  defect                 |         Status:  new
 Priority:  Medium                 |      Milestone:
Component:  Metrics/Onionperf      |        Version:
 Severity:  Normal                 |     Resolution:
 Keywords:  acute-2019-q1-planned  |  Actual Points:
Parent ID:                         |         Points:
 Reviewer:                         |        Sponsor:
-----------------------------------+------------------------------

Comment (by karsten):

 Replying to [comment:9 acute]:
 > Note this also means that all the produced torperf (*tpf) files will
 have all 'DATAPERC{x}' fields equal to 0.0 for transfers that have
 errored. Any thoughts on this/is this likely to affect things futher down
 the data processing pipeline?

 Wait, these fields are
 [https://metrics.torproject.org/collector.html#torperf defined] as
 optional. Setting them to 0.0 would mean setting them to 1970-01-01
 00:00:00.000. Can't we just leave these fields out if the corresponding
 events never happened? Any parser of these files shouldn't rely on these
 fields to be present. After all, these fields haven't been around right
 from the start, and parsers were able to handle those files, too. Does
 this make sense?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29374#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online