[tor-bugs] #29981 [Applications/Tor Browser]: Add option to build without using containers

[Tor Bug Tracker & Wiki]

#29981: Add option to build without using containers
-------------------------------------------------+-------------------------
 Reporter:  boklm                                |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, tbb-8.5-must,               |  Actual Points:
  TorBrowserTeam201904                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, tbb-8.5-must, TorBrowserTeam201904R => tbb-rbm,
     tbb-8.5-must, TorBrowserTeam201904


Comment:

 While still testing the changes here come some preliminary comments:

 commit e38b5d94a19caff488382d92968dbd8cd85b18eb

 The change to the `README` says "Adding the no_containers target will
 disable the use of containers", but the first thing that happens is
 actually building a container (called "empty"). So, we might want to be a
 bit more verbose explaining what is happening here to avoid confusion.

 "and install build dependencies for all the components that are built" We
 are listing build dependencies in the `README` file. I think we should
 list all the additional build dependencies needed for building without
 containers as well while we are talking about them. There should be no
 need for builders that want to build without containers to try figuring
 that out themselves.

 commit 069c880961e93fe2f5052ae6d428b2f9efdd1d4e

 "Add the extensions in sorted order" it's not only extensions it seems?
 So, please adjust the commit message accordingly.

 I wonder why we need `container/use_container` and `container/disable` as
 two separate options. If `use_container` is false then cleary I build
 without containers, no? In other words: why can't we just use/amend the
 already existing `use_container` option to avoid creating another one that
 seems to do the same thing but just (slightly) differently?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29981#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online