[tor-bugs] #30224 [Core Tor/Tor]: Add the tor versions for bridge-distribution-request

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Apr 22 23:36:48 UTC 2019


#30224: Add the tor versions for bridge-distribution-request
--------------------------------+------------------------------------
 Reporter:  teor                |          Owner:  teor
     Type:  defect              |         Status:  needs_review
 Priority:  Medium              |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor        |        Version:
 Severity:  Normal              |     Resolution:
 Keywords:  tor-spec, fast-fix  |  Actual Points:  0.2
Parent ID:                      |         Points:  0.1
 Reviewer:  catalyst            |        Sponsor:  Sponsor19-can
--------------------------------+------------------------------------
Changes (by teor):

 * actualpoints:  0.1 => 0.2


Comment:

 Here's how I found the feature version in tor:
 {{{
 $ git log -S bridge-distribution-request --reverse
 commit ebab521525
 Author: Roger Dingledine <arma at torproject.org>
 Date:   Sun Nov 13 02:39:16 2016 -0500

     Add new BridgeDistribution config option

     Bridge relays can use it to add a "bridge-distribution-request" line
     to their bridge descriptor, which tells BridgeDB how they'd like their
     bridge address to be given out.

     Implements tickets 18329.
 ...
 $ git describe --contains ebab521525
 tor-0.3.2.3-alpha~15^2~4
 }}}

 And here's how I found the backport versions:
 {{{
 $ git log tp/maint-0.3.1 -S bridge-distribution-request --reverse
 commit 9f2efd02a1 (nickm/ticket18329_minimal_025)
 Author: Nick Mathewson <nickm at torproject.org>
 Date:   Mon Nov 13 20:44:51 2017 -0500

     Minimal implementation of bridge-distribution-request

     Just advertise the line when we're a bridge, using "any" if we're
     published or "none" if we aren't.

     This is done in lieu of a full backport of #18329.
 $ git tag --contains 9f2efd02a1 | sort -V
 tor-0.2.5.16
 tor-0.2.8.17
 tor-0.2.9.14
 tor-0.2.9.15
 tor-0.2.9.16
 tor-0.2.9.17
 tor-0.3.0.13
 tor-0.3.1.9
 tor-0.3.1.10
 tor-0.3.2.5-alpha
 ...
 }}}

 I didn't use `sort -V` when I was writing the patch, so I got the 0.3.1
 backport version wrong. I pushed a commit that changes the version to
 0.3.1.9.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30224#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list