[tor-bugs] #28269 [Core Tor/Tor]: Repeated HSFETCH queries fail with QUERY_NO_HSDIR

[Tor Bug Tracker & Wiki]

#28269: Repeated HSFETCH queries fail with QUERY_NO_HSDIR
------------------------------------------+--------------------------------
 Reporter:  atagar                        |          Owner:  neel
     Type:  defect                        |         Status:  needs_revision
 Priority:  Medium                        |      Milestone:  Tor:
                                          |  0.4.1.x-final
Component:  Core Tor/Tor                  |        Version:
 Severity:  Normal                        |     Resolution:
 Keywords:  tor-hs, tor-control tor-spec  |  Actual Points:
Parent ID:                                |         Points:
 Reviewer:  asn                           |        Sponsor:
------------------------------------------+--------------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:16 neel]:
 > I made the corrections necessary.
 >

 Almost there! I meant to initialize the `rate_limited` of
 `hs_pick_hsdir()` not the other one, but again I did not clarify.

 Now, if `responsible_dirs_count` is zero, then `rate_limited` will be
 uninitialized and since it's on stack it can have garbage value, and give
 bad results to `is_rate_limited`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28269#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online