[tor-bugs] #28269 [Core Tor/Tor]: Repeated HSFETCH queries fail with QUERY_NO_HSDIR

[Tor Bug Tracker & Wiki]

#28269: Repeated HSFETCH queries fail with QUERY_NO_HSDIR
------------------------------------------+--------------------------------
 Reporter:  atagar                        |          Owner:  neel
     Type:  defect                        |         Status:  needs_revision
 Priority:  Medium                        |      Milestone:  Tor:
                                          |  0.4.1.x-final
Component:  Core Tor/Tor                  |        Version:
 Severity:  Normal                        |     Resolution:
 Keywords:  tor-hs, tor-control tor-spec  |  Actual Points:
Parent ID:                                |         Points:
 Reviewer:  asn                           |        Sponsor:
------------------------------------------+--------------------------------
Changes (by asn):

 * status:  merge_ready => needs_revision


Comment:

 That looks good but also perhaps let's initialize `rate_limited` to
 `false` just to make it clear and future-proof.

 Also, I think there might be a small bug here in the case where we go in
 `hs_pick_hsdir()` with an empty `responsible_dirs` (as indicated by the
 comment in `directory_get_from_hs_dir()`).  In that case `rate_limited`
 will get toggled to `true` because of `rate_limited = rate_limited_count
 == responsible_dirs_count;`, even tho it should be `false`because the
 issue has nothing to do with rate limiting.

 Putting this back in needs_rev.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28269#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online