[tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:
                                                 |  mikeperry
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,       |
  040-backport, postfreeze-ok                    |
Parent ID:  #29995                               |         Points:  3
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 LGTM!

 I have a slight revision in https://github.com/torproject/tor/pull/969,
 because I opted for not calling the new functions `hs_circ_free()` since
 `*_free()` functions have a very specific meaning in Tor (they free and
 NULL their input). Instead I hijacked `hs_circ_cleanup()` which seamed a
 better target.

 If you like, let's merge_ready.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29034#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online