[tor-bugs] #30051 [Core Tor/Tor]: Add practracker as a pre-commit and pre-push git hook for frequent coders

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Apr 19 11:47:45 UTC 2019


#30051: Add practracker as a pre-commit and pre-push git hook for frequent coders
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  rl1987
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  practracker tech-debt tor-ci git-    |  Actual Points:
  scripts tor-ci-fail-sometimes                  |
Parent ID:  #29792                               |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
                                                 |  Sponsor31-must
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:10 rl1987]:
 > https://github.com/torproject/tor/pull/967


 pretty cool! Almost there, but it seems like the pre-push hook (which is
 the one I'd like to use) does not block the push if practracker complains.
 It does throw the practracker error but does not abort the push (at least
 in my testing with a github branch).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30051#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list