[tor-bugs] #15125 [Obfuscation/meek]: meek-client-torbrowser does not use signals well (was: meek-client-wrapper does not use signals well)

[Tor Bug Tracker & Wiki]

#15125: meek-client-torbrowser does not use signals well
------------------------------+------------------------------
 Reporter:  infinity0         |          Owner:  dcf
     Type:  defect            |         Status:  needs_review
 Priority:  Medium            |      Milestone:
Component:  Obfuscation/meek  |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:                    |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------
Changes (by dcf):

 * status:  new => needs_review


Comment:

 I came around to the timer idea. #25613 rewrites the way that child
 processes are handled in a way that I think addresses this ticket.
   https://gitweb.torproject.org/pluggable-
 transports/meek.git/log/?h=bug25613&id=36d06b5f9a0d0c4a7aa251f33460886f68a2ab22
 Namely these commits:
 * [https://gitweb.torproject.org/pluggable-
 transports/meek.git/commit/?h=bug25613&id=adf41cd3adf6e3884626b6b7e4c7f131660343dd
 Be more careful about terminating meek-client.]
 * [https://gitweb.torproject.org/pluggable-
 transports/meek.git/commit/?h=bug25613&id=1b3a72f3c7208dd7c0471bb3e9077667091874c8
 Be more careful about terminating Firefox.]
 * [https://gitweb.torproject.org/pluggable-
 transports/meek.git/commit/?h=bug25613&id=36d06b5f9a0d0c4a7aa251f33460886f68a2ab22
 Terminate firefox and meek-client simultaneously.]
 The main differences compared to what has already been discussed on this
 ticket are that there are separate `terminatePTCmd` and `terminateCmd`
 functions (`terminatePTCmd` closes stdin, `terminateCmd` does not),
 separate implementations for Windows and non-Windows (Windows doesn't send
 SIGTERM, and its `terminateCmd` kill the process immediately, without any
 timer, and the two terminations run in parallel, not in series.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15125#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online