[tor-bugs] #25613 [Obfuscation/meek]: Close child's stdout to signal exit in meek-client-torbrowser

[Tor Bug Tracker & Wiki]

#25613: Close child's stdout to signal exit in meek-client-torbrowser
------------------------------+------------------------------
 Reporter:  dcf               |          Owner:  dcf
     Type:  enhancement       |         Status:  needs_review
 Priority:  Low               |      Milestone:
Component:  Obfuscation/meek  |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:                    |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------
Changes (by dcf):

 * status:  new => needs_review


Comment:

 Branch bug25613 refactors the way that meek-client-torbrowser handles its
 client processes.
   https://gitweb.torproject.org/pluggable-
 transports/meek.git/log/?h=bug25613&id=36d06b5f9a0d0c4a7aa251f33460886f68a2ab22
   https://gitweb.torproject.org/pluggable-
 transports/meek.git/diff/?h=bug25613&id=36d06b5f9a0d0c4a7aa251f33460886f68a2ab22&id2=29797a33ecee1c6fc4882fc2b6beabcd64f554ce

 [https://gitweb.torproject.org/pluggable-
 transports/meek.git/commit/?h=bug25613&id=adf41cd3adf6e3884626b6b7e4c7f131660343dd
 This] is the commit that touches meek-client. We get a handle to the
 child's stdin:
 {{{
 // ptCmd is a *exec.Cmd augmented with an io.WriteCloser for its stdin,
 which we
 // can close to instruct the PT subprocess to terminate.
 type ptCmd struct {
         *exec.Cmd
         StdinCloser io.WriteCloser
 }
 }}}
 then close it as the first step of terminating the process.
 {{{
         err := cmd.StdinCloser.Close()
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25613#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online