[tor-bugs] #30091 [Core Tor/Tor]: Unify parsing code for control.c

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Apr 17 17:59:29 UTC 2019


#30091: Unify parsing code for control.c
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  enhancement   |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:  3
Parent ID:  #29210        |         Points:  3
 Reviewer:  catalyst      |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------

Comment (by catalyst):

 So far, I looked at
 {{{
 d1f5957c4e Improve handling of controller commands
 }}}
 through
 {{{
 e3fcbffbb8 Use parsing code for the simpler controller commands.
 }}}

 These look good.  I commented on the pull request about a few technical
 debt issues and some minor spelling and naming things.

 This set of commits seems to form a logical grouping and they could
 probably have been in their own child ticket/PR.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30091#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list