[tor-bugs] #30190 [Core Tor/Tor]: Do not warn about compatible OpenSSL upgrades

[Tor Bug Tracker & Wiki]

#30190: Do not warn about compatible OpenSSL upgrades
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  openssl ux usability 035-backport?   |  Actual Points:
  040-backport?                                  |
Parent ID:                                       |         Points:  0.2
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision
 * keywords:  openssl => openssl ux usability 035-backport? 040-backport?


Comment:

 Thanks for the patch!

 Teor is right -- I'm really glad that openssl is aiming for ABI
 compatibility now, but they are still have enough complexity going on that
 I'm not confident that they won't mess it up in the future.

 With that in mind, I'd suggest a middle-ground message. Let's log at
 NOTICE instead of INFO or WARN, and let's say something like "We compiled
 with OpenSSL X and we're running with OpenSSL Y. These two versions should
 be binary compatible."  That way if people do run into bugs some time they
 can report that message.

 Minor bookkeeping: let's base this on maint-0.3.5 rather than master so
 that we can backport it to LTS.  We'll also need a "changes" file as
 described in doc/HACKING/CodingStandards.md.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30190#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online