[tor-bugs] #30051 [Core Tor/Tor]: Add practracker as a post-commit git hook for frequent coders

[Tor Bug Tracker & Wiki]

#30051: Add practracker as a post-commit git hook for frequent coders
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  rl1987
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  practracker tech-debt tor-ci git-    |  Actual Points:
  scripts                                        |
Parent ID:  #29792                               |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 Replying to [comment:5 asn]:
 > An important thing here is that this script won't abort the commit when
 practracker finds issues, which seems like a reasonable idea since maybe
 you want to fix all the practracker issues on a subsequence commit.
 However, this might be a problem for people using git wrappers (like me)
 that ignore git-commit output, since they might not notice the failure.
 Personally, I turned this into a pre-commit hook for this reason, but this
 might not work for other people.
 >
 > Tim, Nick, any opinions here?

 If CI will fail when we push, git should also fail locally.

 But I don't really mind *when* we fail.

 Perhaps we should make it:
 * a pre-commit hook, to encourage frequent coders to write better code
 * a pre-push hook, so mergers don't push branches that will fail CI

 I think some other tickets might do what I want here.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30051#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online