[tor-bugs] #30176 [Core Tor/Tor]: Clear memory in smartlist_remove_keeporder.

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat Apr 13 15:05:06 UTC 2019


#30176: Clear memory in smartlist_remove_keeporder.
------------------------------+------------------------------
 Reporter:  paldium           |          Owner:  (none)
     Type:  defect            |         Status:  new
 Priority:  Medium            |      Component:  Core Tor/Tor
  Version:  Tor: unspecified  |       Severity:  Minor
 Keywords:                    |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+------------------------------
 The smartlist functions take great care to reset unused pointers inside
 the smartlist memory to NULL.

 The function smartlist_remove_keeporder does not clear memory in such
 way when elements have been removed. Therefore call memset after the
 for-loop that removes elements. If no element is removed, it is
 effectively a no-op.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30176>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list