[tor-bugs] #24490 [Core Tor/Tor]: Stop setting bridges running in networkstatus_getinfo_by_purpose()

[Tor Bug Tracker & Wiki]

#24490: Stop setting bridges running in networkstatus_getinfo_by_purpose()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  easy, intro, refactor, code-         |  Actual Points:
  correctness                                    |
Parent ID:                                       |         Points:  1
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Hi neel, thanks, but I wasn't finished with my review.

 I have numbered the changes that we need to make.

 Replying to [comment:6 ahf]:
 > I think the code looks good, but I'm not marking it as ready for merge
 yet. I've just asked the other network team members about how we should
 review the exceptions file for practracker.

 1. I think we can put most of the new flag-setting code in voteflags.c:
 https://github.com/torproject/tor/pull/889/files#r274725520

 In fact, we might not even need a new callback:

 > I've also asked the current bridge auth administrator how they handle
 this currently.

 I bet it just works for them, and they don't know how it works :-)

 v3 (non-bridge) directory authorities update the Running flag when they
 vote.

 But for bridges, the Running flag gets updated in the getinfo function.

 2. For consistency, let's update the bridge Running flag in
 networkstatus_dump_bridge_status_to_file(), before calling
 networkstatus_getinfo_by_purpose().

 Authorities also update the running flag in list_server_status_v1(),
 another control port function.

 3. For consistency, let's stop updating the Running flag in
 list_server_status_v1(), and just let it be updated when the vote/bridge-
 status is written.

 4. For each function we modify, let's update the function documentation.

 5. Let's also update the dir-spec, to document the old and new behaviour.
 The first version with the new behaviour will be 0.4.1.1-alpha, let's put
 that in the spec.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24490#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online