[tor-bugs] #30147 [Core Tor/Tor]: Fix "high-impact" coverity false-positive warnings outside of tests.

[Tor Bug Tracker & Wiki]

#30147: Fix "high-impact" coverity false-positive warnings outside of tests.
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:  nickm
         Type:  defect        |     Status:  assigned
     Priority:  Medium        |  Milestone:  Tor: 0.4.1.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:  #30146
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 Let's fix all the current "high impact" coverity issues that are outside
 of the unit tests.  (For other issues, see siblings of this ticket.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30147>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online