[tor-bugs] #28622 [Applications/Tor Browser]: Update Tor Browser Icon for Android

[Tor Bug Tracker & Wiki]

#28622: Update Tor Browser Icon for Android
-------------------------------------------------+-------------------------
 Reporter:  pili                                 |          Owner:  tbb-
                                                 |  team
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ux-team, tbb-mobile, TBA-a3, tbb-    |  Actual Points:
  parity, tbb-8.5-must-alpha,                    |
  TorBrowserTeam201904R, GeorgKoppen201904       |
Parent ID:  #27399                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Replying to [comment:31 gk]:
 > Replying to [comment:30 sysrqb]:
 [snip]
 > > f1a5708aa82fc832ec4e1d3529f18ae8ceaa217f (tor-browser bug_28622_v3):
 > >
 > > {{{
 > > -ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha
 > >  MOZ_APP_DISPLAYNAME="Tor Browser for Android (Alpha)"
 > > +ANDROID_PACKAGE_NAME=org.torproject.torbrowser_alpha
 > > }}}
 > >
 > > I'm guessing this isn't an important change.
 >
 > No, it's just aligning that file with the layout of the other
 `configure.sh` files (those for stable and nightly).

 Okay.

 >
 [snip]
 > >
 > > This doesn't seems like the result we want, right? Similarly, I'm
 guessing `mobile/android/branding/alpha/locales/en-US/brand.properties`
 was copied from `mobile/android/branding/nightly`, should that use the
 same content as the old torbrowser file?
 >
 > Huh, you are right. I am not sure how this happened, sorry for that. I
 pushed a fixup commit (2ee3e339625a403e6f92618a272264d7353aefdf) on the
 same branch that should correct this for all supported series,

 Thanks, looks good.

 > that is stable (aka official), alpha, and nightly. I am following here
 the desktop lead and don't differentiate the brand names based on series
 but using the same for all three.

 Ah, okay, that was one of my questions. My other question is: Do we want
 to follow Mozilla's lead with the naming in terms of dropping the "for
 Android" tag? Looking a little closer at this, it seems Mozilla used
 "Firefox for Android" only internally, and they branded Fennec as Mozilla
 Firefox (and Firefox for the short name) externally. I don't have much of
 a preference here.

 {{{
 --- a/mobile/android/branding/official/locales/en-US/brand.properties
 +++ b/mobile/android/branding/official/locales/en-US/brand.properties
 @@ -2,5 +2,5 @@
  # License, v. 2.0. If a copy of the MPL was not distributed with this
  # file, You can obtain one at http://mozilla.org/MPL/2.0/.

 -brandShortName=Firefox
 -brandFullName=Mozilla Firefox
 +brandShortName=Tor Browser
 +brandFullName=Tor Browser for Android
 }}}

 and

 {{{
 --- a/mobile/android/branding/official/configure.sh
 +++ b/mobile/android/branding/official/configure.sh
 @@ -2,10 +2,7 @@
  # License, v. 2.0. If a copy of the MPL was not distributed with this
  # file, You can obtain one at http://mozilla.org/MPL/2.0/.

 -MOZ_APP_DISPLAYNAME=Firefox
 -ANDROID_PACKAGE_NAME=org.mozilla.firefox
 +MOZ_APP_DISPLAYNAME="Tor Browser for Android"
 +ANDROID_PACKAGE_NAME=org.torproject.torbrowser
 }}}

 I haven't built all of the series with tor-browser-build, but the changes
 look good to me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28622#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online