[tor-bugs] #29034 [Core Tor/Tor]: circuit: Cleanup an HS circuit when it is being re-purposed

[Tor Bug Tracker & Wiki]

#29034: circuit: Cleanup an HS circuit when it is being re-purposed
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs-reachability, 029-backport-   |  Actual Points:
  maybe, 034-backport-maybe, 035-backport,       |
  040-backport, postfreeze-ok                    |
Parent ID:  #29995                               |         Points:  3
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor27-must
-------------------------------------------------+-------------------------
Changes (by mikeperry):

 * status:  assigned => needs_review


Comment:

 Ok I did the simplest narrow fix, based on what dgoulet said in the
 description:
 https://github.com/torproject/tor/pull/931

 Someone who is deeply familiar with both v2 and v3 state should review
 this. It's simple, and I think it's ok, but I don't know both v2 and v3
 code bases well enough to really be sure.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29034#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online