[tor-bugs] #30110 [Core Tor/Tor]: Add a MapAddress torrc flag that sets chosen_exit_optional to false

[Tor Bug Tracker & Wiki]

#30110: Add a MapAddress torrc flag that sets chosen_exit_optional to false
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  enhancement                          |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  security-low?, tor-client, tor-exit  |  Actual Points:
Parent ID:  #29989                               |         Points:  0.5
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 chosen_exit_optional should already be false for a stream request that
 showed up via a .exit address that was created by a MapAddress config
 line.

 See connection_ap_handshake_rewrite_and_attach() where it sets
 {{{
         conn->chosen_exit_name = tor_strdup(s+1);
 }}}

 and it doesn't set chosen_exit_optional there.

 So, we don't need a new flag here. If it doesn't behave correctly, it's a
 bug that we should just fix.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30110#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online