[tor-bugs] #30078 [Core Tor/Tor]: shellcheck: src/test/fuzz/fixup_filenames.sh issues

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Apr 8 07:59:41 UTC 2019


#30078: shellcheck: src/test/fuzz/fixup_filenames.sh issues
------------------------------+--------------------
     Reporter:  rl1987        |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------
 {{{

 In ./src/test/fuzz/fixup_filenames.sh line 11:
     prev=`basename "$fn"`
          ^--------------^ SC2006: Use $(...) notation instead of legacy
 backticked `...`.


 In ./src/test/fuzz/fixup_filenames.sh line 12:
     post=`sha256sum "$fn" | sed -e 's/ .*//;'`
          ^-- SC2006: Use $(...) notation instead of legacy backticked
 `...`.


 In ./src/test/fuzz/fixup_filenames.sh line 13:
     if [ "$prev" == "$post" ] ; then
                  ^-- SC2039: In POSIX sh, == in place of = is undefined.

 For more information:
   https://www.shellcheck.net/wiki/SC2039 -- In POSIX sh, == in place of =
 is ...
   https://www.shellcheck.net/wiki/SC2006 -- Use $(...) notation instead of
 le...
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30078>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list