[tor-bugs] #30033 [Core Tor/Tor]: The pre-push hook should call the pre-commit hook on every commit

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Apr 5 03:55:17 UTC 2019


#30033: The pre-push hook should call the pre-commit hook on every commit
------------------------------+------------------------------
     Reporter:  teor          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: unspecified
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  git-scripts
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+------------------------------
 Sometimes when I do a change, then merge it forward, the pre-commit hook
 doesn't pick up style errors. That's because the pre-commit hook uses the
 old version of our maint scripts, but then I merge the changes into a
 version with stricter maint scripts.

 Can we call the pre-commit hook on every pushed commit during the pre-push
 hook?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30033>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list