[tor-bugs] #29500 [Core Tor/Tor]: Broken circuitpadding unittests on appveyor

[Tor Bug Tracker & Wiki]

#29500: Broken circuitpadding unittests on appveyor
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:
                                                 |  mikeperry
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  asn-merge, nickm-merge, wtf-pad,     |  Actual Points:  3.5
  tor-relay, tor-cell, padding, 040-must,        |
  040-backport                                   |
Parent ID:  #28631                               |         Points:  3
 Reviewer:  nickm, asn, teor                     |        Sponsor:
                                                 |  Sponsor2
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  wtf-pad, tor-relay, tor-cell, padding, 040-must, 040-backport
     =>
     asn-merge, nickm-merge, wtf-pad, tor-relay, tor-cell, padding,
     040-must, 040-backport
 * reviewer:  nickm => nickm, asn, teor


Comment:

 I backported Mike's extra commit to 0.4.0, then applied the same changes
 as my previous 0.4.0 and master PRs. There was one extra data structure
 name change that I needed to undo then re-apply.

 Here are the final pull requests:
 * 0.4.0: https://github.com/torproject/tor/pull/906
 * master: https://github.com/torproject/tor/pull/907

 So I think everything has been reviewed here multiple times, and we should
 just merge. (But I shouldn't merge, because I did the final PRs.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29500#comment:38>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online