[tor-bugs] #29500 [Core Tor/Tor]: Broken circuitpadding unittests on appveyor

[Tor Bug Tracker & Wiki]

#29500: Broken circuitpadding unittests on appveyor
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:
                                                 |  mikeperry
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.4.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:  3.5
  padding, 040-must, 040-backport                |
Parent ID:  #28631                               |         Points:  3
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor2
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:  wtf-pad, tor-relay, tor-cell, padding, 041-must => wtf-pad,
     tor-relay, tor-cell, padding, 040-must, 040-backport
 * actualpoints:  3 => 3.5


Comment:

 Thanks for the patch. I think I can backport it to 0.4.0 without too much
 trouble.

 I closed #29990, and opened #30031 for the remaining zero delta issue.

 I made a list of all the circumstances where we've seen zero monotonic
 time deltas (or negative deltas, before we added the ratchet). I did some
 more analysis, and I think thoses cases are rare. If they become common,
 we should notice, because our monotonic time unit tests in test/util will
 fail.

 So I don't think we need to block WTF-PAD or 041 on that issue.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29500#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online