[tor-bugs] #29500 [Core Tor/Tor]: Broken circuitpadding unittests on appveyor

[Tor Bug Tracker & Wiki]

#29500: Broken circuitpadding unittests on appveyor
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  wtf-pad, tor-relay, tor-cell,        |  Actual Points:  3
  padding, 041-proposed, 040-must, tor-ci-fail-  |
  sometimes                                      |
Parent ID:  #28631                               |         Points:  3
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor2
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 For 0.4.0, here's what I did:
 * rebased Mike's PR 757 to the current maint-0.4.0
 * deleted a failing test in 0.4.0, because we merged some required fixes
 into master, but didn't backport them,
 * fixed some comments.

 For master, here's what I did:
 * reverted the test deletion,
 * merged 0.4.0 forward to master,
 * weakened the test conditions in the failing test, but left the old
 conditions in the code. We can set ENABLE_BUG_29990_WORKAROUND to false
 once we've fixed #29990. (Or revert that commit.)

 Here are the pull requests:
 * 0.4.0: https://github.com/torproject/tor/pull/893
 * master: https://github.com/torproject/tor/pull/885

 The tests pass on my macOS VM with and without a skewed clock.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29500#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online