[tor-bugs] #29959 [Core Tor/Tor]: Actually include the bandwidth file digest in the vote

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Apr 3 15:25:36 UTC 2019


#29959: Actually include the bandwidth file digest in the vote
----------------------------------------------+----------------------------
 Reporter:  teor                              |          Owner:  teor
     Type:  defect                            |         Status:
                                              |  needs_revision
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  0.4.0.x-final
Component:  Core Tor/Tor                      |        Version:  Tor:
                                              |  0.4.0.2-alpha
 Severity:  Normal                            |     Resolution:
 Keywords:  040-must, 040-backport, fast-fix  |  Actual Points:  0.2
Parent ID:  #29947                            |         Points:  0.2
 Reviewer:  asn                               |        Sponsor:
----------------------------------------------+----------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:1 teor]:
 > See my pull requests:
 > * 0.4.0: https://github.com/torproject/tor/pull/872
 > * master: https://github.com/torproject/tor/pull/873 (for testing only)

 Tiny improvement by removing the nesting altogether, since no retval
 checking is needed:
 https://github.com/torproject/tor/pull/888
 I like removing nesting.

 Feel free to put to merge_ready if you like it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29959#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list