[tor-bugs] #29984 [Core Tor/Tor]: Controller protocol parser can't find empty initial line

[Tor Bug Tracker & Wiki]

#29984: Controller protocol parser can't find empty initial line
--------------------------+------------------------------------
 Reporter:  nickm         |          Owner:  nickm
     Type:  defect        |         Status:  assigned
 Priority:  Medium        |      Milestone:  Tor: 0.4.1.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:  Sponsor31-can
--------------------------+------------------------------------
Description changed by nickm:

Old description:

> We've apparently run into this in a few places before: The code in
> control.c that extracts the command from the command line will discard
> the rest of the line too, if the line is empty.
>
> This means that the control.c code can't distinguish these cases:
> {{{
> FOO A
> B
> C
> .
> }}}
> and
> {{{
> FOO
> A
> B
> C
> }}}

New description:

 We've apparently run into this in a few places before: The code in
 control.c that extracts the command from the command line will discard the
 rest of the line too, if the line is empty.

 This means that the control.c code can't distinguish these cases:
 {{{
 +FOO A
 B
 C
 .
 }}}
 and
 {{{
 +FOO
 A
 B
 C
 }}}

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29984#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online