[tor-bugs] #29036 [Core Tor/Tor]: Coverage merge failures cause test_process_slow stderr check to fail

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Apr 1 04:24:54 UTC 2019


#29036: Coverage merge failures cause test_process_slow stderr check to fail
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Major                                |     Resolution:
 Keywords:  teor-merge, 041-accepted-20190115,   |  Actual Points:  0.5
  regression, tor-ci, 029-backport,              |
  034-backport, 035-backport, 040-backport,      |
  tor-ci-fail-sometimes                          |
Parent ID:                                       |         Points:  0.5
 Reviewer:  catalyst                             |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => needs_review


Comment:

 I added these commits:
 * 57e9fe2: deletes the .gcno and .gcov files in `make reset-gcov`
 * eb0bd18: tweaks the changes file so it passes make check-changes on
 0.3.5
 * clean merge of #29962 into 0.3.4
 * 33be8d8: combine before_cache from #29036 and #29962
 * 7014e57 merge: combine the stem lines from maint-0.3.5 with the moved
 coverage line from #29036

 catalyst, can you review my extra commits on #29036, and my extra commits
 on #29962?
 (You've already reviewed ahf's commits on #29036, and I reviewed rl1987's
 commits on #29962.)

 Here are the pull requests:
 *  0.2.9: https://github.com/torproject/tor/pull/877
 *  0.3.4: https://github.com/torproject/tor/pull/878
   * clean merge to maint-0.3.4, also merge #29962
 *  0.3.5: https://github.com/torproject/tor/pull/879
   * trivial line-based merged to 0.3.5
 *  0.4.0: https://github.com/torproject/tor/pull/881
   * clean merge, testing only
 * master: https://github.com/torproject/tor/pull/882
   * clean merge, testing only

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29036#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list