[tor-bugs] #27785 [Core Tor/Tor]: updateRustDependencies.sh shouldn't use realpath

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Sep 19 23:07:27 UTC 2018


#27785: updateRustDependencies.sh shouldn't use realpath
------------------------------+------------------------------
     Reporter:  catalyst      |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: unspecified
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  rust
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+------------------------------
 updateRustDependencies.sh uses the `realpath` command.  macOS doesn't seem
 to have it, and POSIX doesn't specify it.

 Maybe we should use something like `(cd $x && pwd -P)` instead for greater
 portability.  (Though older shells and OSes might not have the `-P` option
 to `pwd`, it is POSIX.)

 Alternatively, confirm that the current directory is a "reasonable" place
 to run the script from, and use relative pathnames.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27785>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list