[tor-bugs] #23512 [Core Tor/Tor]: Bandwidth stats info leak upon close of circuits with queued cells

[Tor Bug Tracker & Wiki]

#23512: Bandwidth stats info leak upon close of circuits with queued cells
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-bug-bounty, congestion-attack,   |  Actual Points:
  research, watermark, tor-stats, guard-         |
  discovery-stats, 034-triage-20180328,          |
  034-removed-20180328                           |
Parent ID:                                       |         Points:
 Reviewer:  dgoulet                              |        Sponsor:
                                                 |  SponsorQ
-------------------------------------------------+-------------------------
Changes (by mikeperry):

 * status:  needs_revision => merge_ready


Comment:

 Ok I changed the patch's use of approx_time() to time() for consistency
 with rephist.c (which fixes the flapping test for me), and I now check the
 exact byte count in the tests. Otherwise the following branches are
 identical to v3. Setting back to merge_ready.

 0.2.9: https://github.com/torproject/tor/pull/348
 0.3.2: https://github.com/torproject/tor/pull/349
 0.3.3: https://github.com/torproject/tor/pull/350
 0.3.4: https://github.com/torproject/tor/pull/351 (same as 0.3.3, but PR
 against 0.3.4 for CI tests)
 master: https://github.com/torproject/tor/pull/352

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23512#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online