[tor-bugs] #27206 [Core Tor/Tor]: rust protover_all_supported() takes forever on some inputs

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Sep 17 06:55:23 UTC 2018


#27206: rust protover_all_supported() takes forever on some inputs
-------------------------------------------------+-------------------------
 Reporter:  cyberpunks                           |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, protover, 033-backport,        |  Actual Points:
  034-backport                                   |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:11 cyberpunks]:
 > Replying to [comment:10 teor]:
 > > If this change fixes (enough) rust inefficiencies, we should be able
 to re-enable this test as well:
 >
 > Did nickm
 [https://gitweb.torproject.org/tor.git/commit/?id=a5d4ce2b393955f60962d3db8744a846506c3e7b
 disable that test] on rust builds for efficiency reasons? It would only
 allocate 256KiB.
 >
 > It looks like it's disabled because the assert fails.

 We need to fix the Rust code to behave the same as the C code. We should
 have done that back in #25517, but we can do it now, and backport.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27206#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list