[tor-bugs] #27739 [Core Tor/Tor]: rust protover_all_supported() accepts too-long protocol names

[Tor Bug Tracker & Wiki]

#27739: rust protover_all_supported() accepts too-long protocol names
------------------------------+--------------------------
     Reporter:  cyberpunks    |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:
    Component:  Core Tor/Tor  |    Version:  Tor: 0.3.3.6
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------
 [https://gitweb.torproject.org/tor.git/commit/?id=569b4e57e23d728969a12751afc6b45f32d0f093
 569b4e57e23d728969a12751afc6b45f32d0f093] was fixing #25517 but kept the
 old behavior of allowing protocol names of any length for
 `protover_all_supported()`. That's the reason
 [https://gitweb.torproject.org/tor.git/commit/?id=a5d4ce2b393955f60962d3db8744a846506c3e7b
 this unit test was failing, and ended up being disabled on rust builds]
 with a ??? comment of confusion.

 The reason given in the commit for this behavior was `in order to maintain
 compatibility with consensus methods older than 29.` but the corresponding
 [https://gitweb.torproject.org/tor.git/commit/?id=eb966928428a80c105d33bd60bcae5503a1adeb7
 C code change] never made any exception like this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27739>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online