[tor-bugs] #27728 [Core Tor/Tor]: test: Build an HSv3 descriptor with authorized client is apparently broken

[Tor Bug Tracker & Wiki]

#27728: test: Build an HSv3 descriptor with authorized client is apparently broken
--------------------------+------------------------------------
 Reporter:  Hello71       |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:  Tor: unspecified
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by Hello71):

 tor 035166e (master as of about 5 hours ago), gcc 8.2.1 with -O3 -flto and
 other flags. I assume the order is across files due to the LTO.

 It looks like src/ext/ed25519/ref10
 /src_ext_ed25519_ref10_libed25519_ref10_a-keypair.o and
 src/ext/ed25519/donna/src_ext_ed25519_donna_libed25519_donna_a-
 ed25519_tor.o are built without TOR_UNIT_TESTS, so they declare
 crypto_strongest_rand as a function instead of a variable. I checked this
 by putting `#ifndef TOR_UNIT_TESTS #error bad include #endif` in
 src/lib/crypt_ops/crypto_rand.h and then remaking src/test/test, relying
 on automake's dependency tracking.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27728#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online