[tor-bugs] #27717 [Core Tor/Stem]: Report tor segfaults when integ testing

[Tor Bug Tracker & Wiki]

#27717: Report tor segfaults when integ testing
-------------------------------+--------------------------
     Reporter:  atagar         |      Owner:  atagar
         Type:  enhancement    |     Status:  new
     Priority:  High           |  Milestone:
    Component:  Core Tor/Stem  |    Version:
     Severity:  Normal         |   Keywords:  testing easy
Actual Points:                 |  Parent ID:
       Points:                 |   Reviewer:
      Sponsor:                 |
-------------------------------+--------------------------
 From time to time Stem's integration tests crash tor (for example,
 #27500). When this happens our test output is pretty confusing since from
 the point of the crash onward we fail with generic 'cannot connect to tor'
 errors.

 There's two issues here...

 1. Our test output doesn't indicate that tor crashed.

 2. When reporting tor segfaults we need its stacktrace, which is swallowed
 by our tests.

 We should adjust our test's get_tor_controller() helper to check if tor is
 still alive, failing the test with a clearer message if it isn't and
 providing the tor stacktrace at the end of the test run.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27717>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online