[tor-bugs] #27687 [Core Tor/Tor]: rust protover accepts non ASCII in protocol names

[Tor Bug Tracker & Wiki]

#27687: rust protover accepts non ASCII in protocol names
-------------------------------------------------+-------------------------
 Reporter:  cyberpunks                           |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  rust, protover, 033-backport,        |  Actual Points:
  034-backport                                   |
Parent ID:  #27316                               |         Points:
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_revision => merge_ready


Comment:

 Replying to [comment:3 cyberpunks]:
 > Replying to [comment:2 teor]:
 > >  If this branch is already on the latest 0.3.3, can you try merging to
 0.3.4 and master, and provide branches for the non-trivial merges?
 >
 > Done. The conflicts in master were due to the rustfmt changes.

 Thanks!

 I just realised that Appveyor doesn't run rust, so I think we're fine to
 merge rust-protokeyword1 into 0.3.3 and forward, and rust-
 protokeyword1-035 into master. (rust-protokeyword1-034 seems like a
 trivial merge?)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27687#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online