[tor-bugs] #27451 [Core Tor/Tor]: Refactor socket closing in tor_tls_free()

[Tor Bug Tracker & Wiki]

#27451: Refactor socket closing in tor_tls_free()
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-roadmap-master, 035-triaged-     |  Actual Points:
  in-20180711                                    |
Parent ID:  #26631                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  assigned => needs_review


Comment:

 I have a patch here as `nss_27451`, with PR at
 https://github.com/torproject/tor/pull/322 .

 It takes a hybrid approach: by default, the TLS connection object owns the
 socket and closes it when it's freed.  But if something else needs to free
 the socket, ownership is wrested from the TLS connection object.

 The unit tests pass for me, but chutney+nss is failing because of #27664.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27451#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online