[tor-bugs] #27649 [Core Tor/Tor]: rust protover double-counts protocol versions

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Sep 12 03:00:07 UTC 2018


#27649: rust protover double-counts protocol versions
----------------------------+------------------------
 Reporter:  cyberpunks      |          Owner:  (none)
     Type:  defect          |         Status:  new
 Priority:  Medium          |      Milestone:
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  rust, protover  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:                  |        Sponsor:
----------------------------+------------------------

Comment (by cyberpunks):

 Attempt at fixing this in branch rust-protoverlap1 at
 https://gitgud.io/onionk/tor.git

 Writing that, it also seems like leaving version zero as a reserved value
 is useful for protover implementations like this, since 0 is the initial
 value of `last_high` as a placeholder for 'no version seen yet.'

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27649#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list