[tor-bugs] #26381 [Applications/Tor Browser]: about:tor page does not load on first start on Windows and browser is stuck in endless reload cycle

[Tor Bug Tracker & Wiki]

#26381: about:tor page does not load on first start on Windows and browser is stuck
in endless reload cycle
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:
                                                 |  pospeselr
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton, ff60-esr,             |  Actual Points:
  TorBrowserTeam201808R, TorBrowserTeam201809R   |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by brade):

 Mark and I spent some time looking at potential problems with making this
 change. Tor Launcher intentionally hooks in early so it can temporarily
 block certain things such as network activity.

 We specifically looked at the code that executes between `profile-after-
 change` and `final-ui-startup`. Here are the things we saw that concerned
 us:

 * Command line processing. This will not cause problems because the final
 processing that handles things such as URLs passed on the command line is
 deferred until after `final-ui-startup`.
 * Creation of the hidden window. As far as Mark and I know, the hidden
 window is mainly used to support event processing and Mac menu commands.
 Therefore, we don't think it will be a problem if the hidden window is
 created before Tor Launcher is loaded.
 * Startup of components that have the `profile-after-change` category. We
 think this one is an issue. For example, after applying the proposed fix
 we saw the update service attempt an update ping while the Tor Launcher
 initial configuration window was open.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26381#comment:31>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online