[tor-bugs] #20700 [Core Tor/Tor]: prop224: Implement standard client authorization

[Tor Bug Tracker & Wiki]

#20700: prop224: Implement standard client authorization
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  haxxpop
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, 035-roadmap-        |  Actual Points:
  master, 035-triaged-in-20180711                |
Parent ID:  #25955                               |         Points:  3
 Reviewer:  nickm                                |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by asn):

 If you supply a corrupted privkey (e.g. wrong length) on the client-side
 you get the following assert:
 {{{
 Sep 07 15:04:28.397 [err] tor_assertion_failed_(): Bug:
 src/lib/encoding/binascii.c:100: base32_decode: Assertion (nbits/8) <=
 destlen failed; aborting. (on Tor 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.397 [err] Bug: Assertion (nbits/8) <= destlen failed in
 base32_decode at src/lib/encoding/binascii.c:100. Stack trace: (on Tor
 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.397 [err] Bug:     ./src/app/tor(log_backtrace_impl+0x45)
 [0x555d5b50da95] (on Tor 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.397 [err] Bug:
 ./src/app/tor(tor_assertion_failed_+0x94) [0x555d5b5091d4] (on Tor 0.3.5.0
 -alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.397 [err] Bug:     ./src/app/tor(base32_decode+0x2cf)
 [0x555d5b4f0a9f] (on Tor 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.397 [err] Bug:
 ./src/app/tor(hs_config_client_authorization+0x1d2) [0x555d5b40cf02] (on
 Tor 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.397 [err] Bug:
 ./src/app/tor(hs_config_client_auth_all+0x2e) [0x555d5b4abf9e] (on Tor
 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.398 [err] Bug:     ./src/app/tor(+0x16693e)
 [0x555d5b48c93e] (on Tor 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.398 [err] Bug:
 ./src/app/tor(options_init_from_string+0x419) [0x555d5b490bb9] (on Tor
 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.398 [err] Bug:
 ./src/app/tor(options_init_from_torrc+0x450) [0x555d5b4911a0] (on Tor
 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.398 [err] Bug:     ./src/app/tor(tor_init+0x303)
 [0x555d5b3802e3] (on Tor 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.398 [err] Bug:     ./src/app/tor(tor_run_main+0x6d)
 [0x555d5b380d8d] (on Tor 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.398 [err] Bug:     ./src/app/tor(tor_main+0x3a)
 [0x555d5b37a0ba] (on Tor 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.398 [err] Bug:     ./src/app/tor(main+0x19)
 [0x555d5b379e09] (on Tor 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.398 [err] Bug:     /lib/x86_64-linux-
 gnu/libc.so.6(__libc_start_main+0xe7) [0x7ff681179a87] (on Tor 0.3.5.0
 -alpha-dev 0b60cc10f5536b17)
 Sep 07 15:04:28.398 [err] Bug:     ./src/app/tor(_start+0x2a)
 [0x555d5b379e5a] (on Tor 0.3.5.0-alpha-dev 0b60cc10f5536b17)
 }}}

 We can fix either now or after the thing is merged.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20700#comment:45>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online