[tor-bugs] #17520 [Core Tor/Tor]: Relax the rend cache failure cleanup timer

[Tor Bug Tracker & Wiki]

#17520: Relax the rend cache failure cleanup timer
-----------------------------------------+---------------------------------
 Reporter:  dgoulet                      |          Owner:  neel
     Type:  enhancement                  |         Status:  needs_revision
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.3.5.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  tor-hs, tor-client, prop224  |  Actual Points:
Parent ID:  #23300                       |         Points:  1
 Reviewer:  dgoulet                      |        Sponsor:  Sponsor8-can
-----------------------------------------+---------------------------------

Comment (by neel):

 I got it passing tests provided I remove this code from
 `src/test/test_hs_client.c` (function `test_client_pick_intro()`:

 {{{
     /* Now also mark the chosen one as failed: See that we can't get any
 intro
        points anymore. */
     hs_cache_client_intro_state_note(&service_kp.pubkey,
 &chosen_intro_point->auth_key_cert->signed_key,
                                      INTRO_POINT_FAILURE_TIMEOUT);
     extend_info_t *ip = client_get_random_intro(&service_kp.pubkey);
     tor_assert(!ip);
 }}}

 The reason why I think it's okay to remove this is because
 `hs_cache_client_intro_state_find()` and
 `hs_cache_client_intro_state_note()` would be calling
 `hs_cache_client_intro_state_clean()` which does it (and this test fails
 from the code I mentioned above if I did not delete it).

 It is already committed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17520#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online