[tor-bugs] #17520 [Core Tor/Tor]: Relax the rend cache failure cleanup timer

[Tor Bug Tracker & Wiki]

#17520: Relax the rend cache failure cleanup timer
-----------------------------------------+---------------------------------
 Reporter:  dgoulet                      |          Owner:  neel
     Type:  enhancement                  |         Status:  needs_revision
 Priority:  Medium                       |      Milestone:  Tor:
                                         |  0.3.5.x-final
Component:  Core Tor/Tor                 |        Version:
 Severity:  Normal                       |     Resolution:
 Keywords:  tor-hs, tor-client, prop224  |  Actual Points:
Parent ID:  #23300                       |         Points:  1
 Reviewer:  dgoulet                      |        Sponsor:  Sponsor8-can
-----------------------------------------+---------------------------------

Comment (by neel):

 Replying to [comment:17 dgoulet]:
 > You probably simply want to call `hs_cache_client_intro_state_clean()`
 before calling `cache_client_intro_state_lookup()` ... or something around
 those lines :).

 I tried this, and get errors like this:

 {{{
 hs_client/client_pick_intro: [forking] Sep 05 20:12:27.607 [err]
 tor_assertion_failed_: Bug: src/test/test_hs_client.c:431:
 test_client_pick_intro: Assertion !ip failed; aborting. (on Tor 0.3.5.0
 -alpha-dev e3d1c98f6add4d09)
 Sep 05 20:12:27.613 [err] Bug: Assertion !ip failed in
 test_client_pick_intro at src/test/test_hs_client.c:431. Stack trace: (on
 Tor 0.3.5.0-alpha-dev e3d1c98f6add4d09)
 Sep 05 20:12:27.613 [err] Bug:     0x165515c <log_backtrace_impl+0x4c> at
 /usr/home/neel/code/tor/tor/src/test/test (on Tor 0.3.5.0-alpha-dev
 e3d1c98f6add4d09)
 Sep 05 20:12:27.613 [err] Bug:     0x1651420 <tor_assertion_failed_+0xa0>
 at /usr/home/neel/code/tor/tor/src/test/test (on Tor 0.3.5.0-alpha-dev
 e3d1c98f6add4d09)
 Sep 05 20:12:27.613 [err] Bug:     0x1390475
 <dir_common_construct_vote_3+0x57cb5> at
 /usr/home/neel/code/tor/tor/src/test/test (on Tor 0.3.5.0-alpha-dev
 e3d1c98f6add4d09)
 Sep 05 20:12:27.613 [err] Bug:     0x14ac573 <testcase_run_one+0x373> at
 /usr/home/neel/code/tor/tor/src/test/test (on Tor 0.3.5.0-alpha-dev
 e3d1c98f6add4d09)
 Sep 05 20:12:27.614 [err] Bug:     0x14ac9ff <tinytest_main+0x1af> at
 /usr/home/neel/code/tor/tor/src/test/test (on Tor 0.3.5.0-alpha-dev
 e3d1c98f6add4d09)
 Sep 05 20:12:27.614 [err] Bug:     0x14ab9f3 <main+0x2f3> at
 /usr/home/neel/code/tor/tor/src/test/test (on Tor 0.3.5.0-alpha-dev
 e3d1c98f6add4d09)
 [Lost connection!]
   [client_pick_intro FAILED]
 }}}

 I am thinking about calling `hs_cache_client_intro_state_clean()` in
 `cache_client_intro_state_lookup()`. Is this okay?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17520#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online