[tor-bugs] #17835 [Core Tor/Tor]: Make ClientPreferIPv6ORPort smarter

[Tor Bug Tracker & Wiki]

#17835: Make ClientPreferIPv6ORPort smarter
-----------------------------+----------------------------------
 Reporter:  teor             |          Owner:  neel
     Type:  defect           |         Status:  assigned
 Priority:  Medium           |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  tor-client ipv6  |  Actual Points:
Parent ID:  #17811           |         Points:  medium/large
 Reviewer:                   |        Sponsor:
-----------------------------+----------------------------------

Comment (by neel):

 Also, I am thinking about making `tor_addr_is_local()` a macro for
 `tor_addr_is_internal_()` like we do with `tor_addr_is_internal()`, but
 add a flag for `tor_addr_is_internal_()` that determines whether we should
 only check local networks (where `tor_addr_is_local()` would use 1 and
 `tor_addr_is_internal()` would use 0). Is this okay? Or should I just make
 a `tor_addr_is_local_()`?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17835#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online