[tor-bugs] #24661 [Core Tor/Tor]: accept a reasonably live consensus for guard selection

[Tor Bug Tracker & Wiki]

#24661: accept a reasonably live consensus for guard selection
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:
                                                 |  catalyst
     Type:  defect                               |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  bootstrap, clock-skew,               |  Actual Points:
  s8-bootstrap, s8-errors, ux,                   |
  033-triage-20180320, 034-roadmap-proposed,     |
  034-triage-20180328, 034-included-20180328,    |
  034-deferred-20180602, 035-removed-20180711    |
Parent ID:  #23605                               |         Points:  1
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8-can
-------------------------------------------------+-------------------------

Comment (by nickm):

 I think that it is fine to make this change.  It's normal for clients to
 use guards that are chosen based on past consensuses.

 It might be good to make sure that we have at least tried to fetch a live
 consensus before we do this, though.  Maybe we should have the test be
 "have_reasonably_live_consensus() ||
 have_received_a_consensus_in_the_last_N_hours()"?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24661#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online