[tor-bugs] #28136 [Metrics/Website]: OnionPerf graph handles missing data on 2018-10-01 in a weird way

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Oct 30 16:29:59 UTC 2018


#28136: OnionPerf graph handles missing data on 2018-10-01 in a weird way
-----------------------------+-----------------------------
 Reporter:  karsten          |          Owner:  karsten
     Type:  defect           |         Status:  merge_ready
 Priority:  High             |      Milestone:
Component:  Metrics/Website  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+-----------------------------

Comment (by karsten):

 Replying to [comment:5 irl]:
 > Ok. This change looks good.

 Great! Merged and deployed. The update is going to take until tomorrow
 afternoon.

 > There is another function to sanitize the data from the database,
 `emptyNull`, which perhaps could do with either a better name or some
 JavaDoc. I can see what it does looking at the code but was confused
 looking at the code above that called it.

 Agreed, there's room for improvement here. I'll think more about it and
 post a patch here tomorrow.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28136#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list