[tor-bugs] #28193 [Core Tor/Tor]: Compile-time assertion

[Tor Bug Tracker & Wiki]

#28193: Compile-time assertion
--------------------------+----------------------------------
 Reporter:  riastradh     |          Owner:  (none)
     Type:  enhancement   |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  nickm         |        Sponsor:
--------------------------+----------------------------------

Comment (by nickm):

 1. Do we need to wrap "x" in parentheses when we pass it it to the other
 macros?  For example, instead of

 {{{
 #define CTASSERT(x) CTASSERT_EXPN(x, c, __COUNTER__)
 }}}

 shouldn't we say

 {{{
 #define CTASSERT(x) CTASSERT_EXPN((x), c, __COUNTER__)
 }}}
 ?

 2. Are you sure ATTR_UNUSED is needed?  C doesn't usually complain about
 unused typedefs, I think.

 3. Also, how strongly do you feel about the copyright/license block here?
 If you use the standard Tor one, we don't have to add a new section to
 LICENSE, but if you use this one, we do have to add a new section (since
 the license says we need to distribute it along with our binaries).  I'm
 fine with doing that if you want us to, but it's slightly more convenient
 if we don't.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28193#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online