[tor-bugs] #28157 [Applications/Tor Browser]: Upstream neersighted's patch for cross-compiling Rust for Windows

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Oct 30 07:27:52 UTC 2018


#28157: Upstream neersighted's patch for cross-compiling Rust for Windows
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  task                      |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  GeorgKoppen201810         |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by gk):

 Replying to [comment:2 alexcrichton]:
 > As an update here, I've been commenting (https://github.com/rust-
 lang/rust/pull/55444#issuecomment-434015059) on that PR, but unfortunately
 this patch I don't think we can land upstream because it doesn't really
 produce a workable target (panics don't run destructors).
 >
 > For Tor though how much of this actually matters? I was under the
 impression that Firefox compiles with `-C panic=abort` which would bypass
 the exception runtime anyway. Does tor also do that or intentionally not
 do that? (or accidentally forget to pass a flag that does that?) Or does
 `-C panic=abort` still have linking issues?

 Firefox is fine. The problem is that we don't get a properly functioning
 rust compiler compiled for the i686 mingw target due the exception
 handling issue (compiling with `panic=abort` does not work and
 `panic=unwind` is broken as well). And we build the compiler from source
 partly because we expected that we needed to deal with issues like #26475.
 :)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28157#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list