[tor-bugs] #27198 [Core Tor/Tor]: protover doesn't forbid version zero

[Tor Bug Tracker & Wiki]

#27198: protover doesn't forbid version zero
--------------------------+------------------------------------
 Reporter:  cyberpunks    |          Owner:  (none)
     Type:  defect        |         Status:  needs_information
 Priority:  Medium        |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor  |        Version:  Tor: 0.2.9.4-alpha
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  teor          |        Sponsor:
--------------------------+------------------------------------
Changes (by teor):

 * reviewer:   => teor


Comment:

 Replying to [comment:6 teor]:
 > Replying to [comment:5 cyberpunks]:
 > > Problem: it looks like there's already code that depends on there
 being no version 0, in protover_all_supported().
 >
 > Can you be more specific?
 >
 > Which code allows 0 versions, and which code doesn't?
 > And what happens in the vote and the consensus when a 0 version is
 specified by a relay?

 We can't resolve the spec issues, #27201, and #27198 until these questions
 are answered.

 Also, this branch seems to have a lot of unrelated changes in it.
 Can you please cherry-pick the "zero" changes on top of master?

 If you can't do these things, just let us know, and we will do them
 eventually.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27198#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online