[tor-bugs] #28127 [Core Tor/Tor]: Hidden service option HiddenServiceAuthorizeClient is incompatible with version 3

[Tor Bug Tracker & Wiki]

#28127: Hidden service option HiddenServiceAuthorizeClient is incompatible with
version 3
-----------------------------+------------------------------------
 Reporter:  pege             |          Owner:  neel
     Type:  defect           |         Status:  needs_review
 Priority:  Medium           |      Milestone:  Tor: 0.3.5.x-final
Component:  Core Tor/Tor     |        Version:  Tor: 0.3.5.1-alpha
 Severity:  Normal           |     Resolution:
 Keywords:  tor-hs, hs-auth  |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------------
Changes (by neel):

 * status:  needs_revision => needs_review


Comment:

 In `config_learn_service_version()`, a call to
 `hs_service_get_version_from_key()` is made (which ends up returning `-1`
 on no key) and the code looks like this:

 {{{
   version = hs_service_get_version_from_key(service);
   if (version < 0) {
     version = service->config.version;
   }
 }}}

 This means that if `hs_service_get_version_from_key()` is `-1`, then the
 version is automatically used. I did some debugging and a
 `hs_service_get_version_from_key()` of `-1` with no `HiddenServiceVersion`
 returns a `config_learn_service_version()` of `3`.

 Setting this as `needs_review` as I don't think there is a bug and this
 case is already handled. If there is, would you be willing to clarify?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28127#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online